Source Activity

Syndicate content
Updated: 16 min 54 sec ago

Style fixes, no functional changes.

Wed, 2014-07-16 15:57
Style fixes, no functional changes.
Categories: Development

Parse multiple HTTP at once

Wed, 2014-07-16 15:34
Parse multiple HTTP at once

Instead of relying on the global protocol loop to call _ParseHeaders
once for each header, extract as much as possible from the current
buffer.

This saves memory, avoids useless operations on the socket and various
processing steps, and fixes #10245.

Also improve the handling of 0-size requests to make sure they terminate
properly.
Categories: Development

Rewrite "open containing folder" in a safer way.

Wed, 2014-07-16 14:24
Rewrite "open containing folder" in a safer way.

* Tracker has support for this in its RefsReceived handler, which
results in simpler code than going through BRoster to open the folder.
* Avoids a race condition, possible confusion of Tracker windows with
the same title, and makes the code more readable (and working).
* Fixes #11008.

Thanks to Axeld for pointing the support in RefsReceived, which wasn't
used anywhere outside of Tracker, yet.
Categories: Development

Extend Tracker scripting capabilities

Wed, 2014-07-16 13:53
Extend Tracker scripting capabilities

* Allow EXECUTE on the Folder property to open a window for the passed
ref and return a BMEssenger targetting that window.
* Allog GET on the Folder property to return a messenger to the matching
window, if one is already open.
* Make scripting support mandatory and remove the define allowing to
disable it.
Categories: Development

Move automount settings to the Tracker preferences

Wed, 2014-07-16 12:46
Move automount settings to the Tracker preferences

* Avoids the ugly "button that opens another window" UI paradigm in
Tracker preferences.
* Makes it possible to revert changes to the automount settings as the
Tracker preferences window has a revert button.
Categories: Development

Fix Coverity bug 1108392: Stray semicolon

Tue, 2014-07-15 20:17
Fix Coverity bug 1108392: Stray semicolon

Signed-off-by: Philippe Saint-Pierre 
Categories: Development

CID 1108469: Use after free

Tue, 2014-07-15 20:11
CID 1108469: Use after free
Categories: Development

CID 991761: potential double close (and white space fix)

Tue, 2014-07-15 19:34
CID 991761: potential double close (and white space fix)
Categories: Development

Fix Coverity bug 603941: Negative array index read

Tue, 2014-07-15 19:14
Fix Coverity bug 603941: Negative array index read

Signed-off-by: Philippe Saint-Pierre 
Categories: Development

CID 1162772: Missing break (and typos fixed)

Tue, 2014-07-15 18:46
CID 1162772: Missing break (and typos fixed)
Categories: Development

Style fix, no functional changes

Tue, 2014-07-15 18:06
Style fix, no functional changes

Thanks Axel!
Categories: Development

FFMPEG plugin: Refactor video decoding function.

Tue, 2014-07-15 13:49
FFMPEG plugin: Refactor video decoding function.

- We factor out the code that does the decoding, deinterlacing and color space
  converting into its own function. This prepares auto detection of video frame
  properties in a later commit. Auto detection means (for example), that you
  don't need to know the size of the decoded video frame -before- intitializing
  the video codec as it is the case with the current implementation.

- Use the already existent private member variable fHeader to fill out and
  return video frame properties.

- Rename some variables to be more self describing.

- No functional change intended.

Signed-off-by: Colin Günther 
(cherry picked from commit 6beab04f48e98022041895750f38c5a35a5f4f9e)
Categories: Development

FFMPEG plugin: Add links to useful FFMPEG-API documentation.

Tue, 2014-07-15 13:49
FFMPEG plugin: Add links to useful FFMPEG-API documentation.

- As it is rather hard to find useful documentation, on how to use FFMPEG's API
  we cut of some research time by just documenting it at the place where it is
  most visible to other FFMPEG plugin developers :)

Signed-off-by: Colin Günther 
(cherry picked from commit b0ed15d2196ca45de8ab2d5913d760602aacc5f3)
Categories: Development

FFMPEG plugin: Use member variables instead of local ones.

Tue, 2014-07-15 13:49
FFMPEG plugin: Use member variables instead of local ones.

- This small refactoring is in preparation for implementing decoding of partial
  video frame data, where one needs to preserve encoded data between multiple
  calls to  AVCodecDecoder::_DecodeVideo().

- Note: The names fChunkBuffer and fChunkBufferSize are open for discussion.
  I'd rather prefer fEncodedDataChunkBuffer and fEncodedDataChunkBufferSize.
  But I'd like to take small refactoring steps, and changing the naming would
  also touch the AVCodecDecoder::_DecodeAudio() function. I'd rather focus
  on improving the video part for now, leaving the audio part alone.

- No functional change intended.

Signed-off-by: Colin Günther 
(cherry picked from commit f2da1e752458b926aebe50642bf6af19e9903f17)
Categories: Development

Ticket #3385: inconsistencies when single window + disks icon

Tue, 2014-07-15 01:16
Ticket #3385: inconsistencies when single window + disks icon

When using the Show Disks icon option, single window navigaton mode,
and starting navigation by the Disks icon, these bugs would occurs
upon entering child poses :

*) The draggable icon at the top right wouldn't appear
*) The file menu wouldn't update properly (for example, the New folder
menu item won't show)

Based in part on dru_ed's patch.
Categories: Development

Add newline to end of BShape docs

Mon, 2014-07-14 23:16
Add newline to end of BShape docs
Categories: Development

BShape: Rename these params back in header.

Mon, 2014-07-14 23:15
BShape: Rename these params back in header.

Accidentally renamed these in the header, rename them back to
match the cpp file. These param names might not be very good but
they match the struct variable names. They are private methods
anyway. No functional change intended in either commit.
Categories: Development

Document BShape and BShapeIterator

Mon, 2014-07-14 23:03
Document BShape and BShapeIterator
Categories: Development

BShape: Style fixes for docs

Mon, 2014-07-14 23:02
BShape: Style fixes for docs
Categories: Development