Latest Bugs & Tasks
Edited and applied patch from Puck Meerburg in hrev46393.
If source strings are wrong, this strings will be not null-terminated. I dont know what are this source strings, but this code willn't affect execution speed and will shut-up programs for static analysis.
My Thinkpad X200 has an internal SD card reader. This doesn't work in Haiku. Relevant syslog message:
KERN: usb error ehci -1: qtd (0xa349b80) error: 0x00088d40 KERN: usb_disk: operation 0x25 failed at the SCSI level KERN: usb_disk: failed to update capacity: Device media changed by@
[Device /dev/bus/usb/7/5] Class .................. 0x00 (Per-interface classes) Subclass ............... 0x00 Protocol ............... 0x00 Max Endpoint 0 Packet .. 64 USB Version ............ 0x0200 Vendor ID .............. 0x05ca (Ricoh Co., Ltd) Product ID ............. 0x1880 Product Version ........ 0x0001 Manufacturer String .... "RICOH " Product String ......... "USB2.0-FLASH Media " Serial Number .......... "R5U880-00003" [Configuration 0] Configuration String . "" [Interface 0] [Alternate 0 active] Class .............. 0x08 (Mass storage) Subclass ........... 0x06 Protocol ........... 0x50 Interface String ... "" [Endpoint 0] MaxPacketSize .... 512 Interval ......... 0 Type ............. Bulk Direction ........ Input [Endpoint 1] MaxPacketSize .... 512 Interval ......... 0 Type ............. Bulk Direction ........ Output
Removing the card and inserting it again seems to work.
Found this in Coverity, CID:1108404
But, I'm 99% sure it is just false positive. I created tihs ticket because it may be serious bug.
Method BuildReportList reads what contains table of pointers of second parameter. But, this was uninitialized.
I saw this is 99% false positive because if it's kernel mode this willn't crash machine. But I saw preprocessor constant with word USERLAND and I'm not sure if it's kernel mode. If it's, setting this array to nulls is probably only wasting cpu cycles.
DoublyLinkedListImpl intentionally doesn't have a virtual destructor, since it shall be usable also for classes that aren't supposed to be polymorphic.
The missing virtual keyword for the PackageNode destructor has been added in 6ef9697b0028d73bf381f4b2dde87dd407c552bc. Derived classes automatically inherit the virtual destructor, so theirs doesn't need to be marked anymore.
empty virtual destructor in DoublyLinkedListImpl:
There is some derivatives, such as PackageNode. If someone assign ptr to PackageNode to DoublyLinkedListImpl<PackageNode>* there will be memleak.
Virtual destructors in PackegeSymlink and PackageDirectory:
I don't know if they have childs, but they could have.
I've fount this in Coverity CID:1108472, wanted to fix it but it seems someone was faster, and there is virtual destructor in PackageNode class.
At Restart, Haiku shotdown and shows a Black/Blue screen! Laptop hangs. Start Button did not work anymore. Just removing the Power connection or the Battery and push it back helps.
Laptop is from Gericom (Webgine)! Haiku can't find USB-Stick or Wireless USB-Mouse. With WinXP no problems.
Device is an old Laptop from Gericom (Webgine)! Connecting wire to the Laptop and takes 3 Minutes to configure Network. After that Network shows green light. Web+ opens with an error message. Same Machine with WinXP works. Take a look at the Pictures.
This is hrev46303.
Here's a little mockup to see if icons as buttons may be nicer than the current text-buttons:
The originals "Remove" button might confuse a user, thinking it'll delete the downloaded file.
I'd also propose to have a simple "Clear list" at the bottom that removes all finished or missing entries. Paused or downloaded entries remain.
The "Pause" icon toggles with "Play", of course.
2nd icon is "Open parent folder".
3rd icon is to remove the entry.
You open a file by double-clicking the file icon. All commands should also be available via context menu, plus a "Get info" entry opening a window with more info like MIME type, file size, origin URL etc. Bubble helps for all icons
I'd also prefer a grey background, similar to Tracker's copy window.
No, it shows a blank page. Support for directory listing could be added. I have checked, and Chromium does it, for example.
Now, should this be done in WebKit or in Services Kit ?
Fixed in hrev46384.
No issues on youtube anymore.