Development mailing list

Syndicate content
Archive of posts for haiku-development at FreeLists
Updated: 1 hour 6 min ago

[haiku-development] Re: Vote for commit access for Jonathan Schiefer / js / midar (Jonathan Schleifer)

Thu, 2014-01-02 16:45
Am 17.12.2013 um 08:03 schrieb Adrien Destugues pulkomandy@xxxxxxxxx: Since we still want him to show us he's able to fully comply with the guidelines, I'd rather review a patchset with those fixes, split in several smaller commits, for example each fixing a different issue with non-standard C++. And here would be another patch set ;) ...
Categories: Development

[haiku-development] Re: Apply Clang work from midar-github.master (Ingo Weinhold)

Thu, 2014-01-02 10:45
On 12/17/2013 05:28 PM, Jonathan Schleifer wrote: Am 17.12.2013 um 16:08 schrieb Ingo Weinhold ingo_weinhold@xxxxxx: If one currently has uncommitted changes, one would also need to stash them. If one doesn't really want to rebase them to the current master yet, one would have to create a separate branch first. It's not that much work, but at least some reason to postpone applying a patch. ...
Categories: Development

[haiku-development] Re: Apply Clang work from midar-github.master (Jonathan Schleifer)

Thu, 2014-01-02 10:45
Am 17.12.2013 um 17:34 schrieb Urias McCullough umccullough@xxxxxxxxx: I don't think anyone was contemplating *how* it should work - it's the act of setting up such a system, complete with Trac integration, that has been preventing such a system from being implemented. Well, a queue branch would be just a normal Git branch, thus already be integrated into Git ;). Committers could just commit it to the queue branch if it looks good, without even needing to test if it compiles. So all that's missing is the build bot. ...
Categories: Development

[haiku-development] Re: Apply Clang work from midar-github.master (Urias McCullough)

Thu, 2014-01-02 10:45
On Tue, Dec 17, 2013 at 8:28 AM, Jonathan Schleifer js-haiku-development@xxxxxxxxxxx wrote: The testing part could be solved by a queue branch: A bot periodically builds the queue branch and if that works, someone can cherry-pick the changes from the queue branch after 48h. The diffs are cherry-picked so that the history mess of that queue branch does not get into master. So a patch could go instantly into the queue branch and if it is rejected, a simple git revert on the queue branch would revoke that patch. The master branch can be merged into the queue branch regularly so that patches in the queue branch are based on a current master. This creates quite a patch + revert mess in the history, ...
Categories: Development

[haiku-development] Re: Apply Clang work from midar-github.master (Jonathan Schleifer)

Thu, 2014-01-02 08:45
Am 17.12.2013 um 16:08 schrieb Ingo Weinhold ingo_weinhold@xxxxxx: Unfortunately applying a patch doesn't only take a few seconds -- at least doing it the right way doesn't. It involves at least building the changed sources (unless the patch only affects comments or a ReadMe) and better yet also testing the changed code. Ideally doing that for both gcc versions (though, understandably, people rarely do). If one currently has uncommitted changes, one would also need to stash them. If one doesn't really want to rebase them to the current master yet, one ...
Categories: Development