Source Activity

Syndicate content
Haiku's main repository
Updated: 52 min 9 sec ago

Tracker: fix localization of warning when editing system dirs

Sun, 2016-08-21 14:42
Programatically generating a string usually doesn't work well with localization. Better unfold all the possiblities. Moreover, the callers of the functions had a long if condition with 3 B_TRANSLATE calls embedded in, and there was an erroneous ; at the end of those, so the supposedly protected statement was executed anyway. Fixes #12747. Programatically generating a string usually doesn't work well with localization. Better unfold all the possiblities. Moreover, the callers of the functions had a long if condition with 3 B_TRANSLATE calls embedded in, and there was an erroneous ; at the end of those, so the supposedly protected statement was executed anyway. Fixes #12747.
Categories: Development

Terminal: remove limitation to 6 tabs

Sun, 2016-08-21 14:38
- This has been bothering me for quite a while. My screen is wide enough to accomodate more, and even if they don't fit the BTabView, it's still possible to navigate many more tabs with the keyboard shortcuts. - We should still remember to fix BTabView to accomodate more tabs than it can fit with some scrolling support or similar, however. - This has been bothering me for quite a while. My screen is wide enough to accomodate more, and even if they don't fit the BTabView, it's still possible to navigate many more tabs with the keyboard shortcuts. - We should still remember to fix BTabView to accomodate more tabs than it can fit with some scrolling support or similar, however.
Categories: Development

Package kit: more style fixes.

Sun, 2016-08-21 14:36
Pointed out by Axel this time. Thanks! Pointed out by Axel this time. Thanks!
Categories: Development

Fix mixed indentation

Sun, 2016-08-21 14:05
Fixes #12758. Fixes #12758.
Categories: Development

Fix mixed indentation.

Sun, 2016-08-21 14:02
This file uses a mix of tab styles, which gcc6 will warn about because it sees "misleading indentation". Fix the function where this happens. Fixes #12759. This file uses a mix of tab styles, which gcc6 will warn about because it sees "misleading indentation". Fix the function where this happens. Fixes #12759.
Categories: Development

chroot support in package kit: style fixes

Sun, 2016-08-21 07:13
- Catching an exception in the normal flow is not a good thing, instead, test before calling the function (I've been doing too much python lately) - Avoid using uninitialized nodeRef if there is no system root and also no specified root in the message. Thanks to Ingo or the code review. - Catching an exception in the normal flow is not a good thing, instead, test before calling the function (I've been doing too much python lately) - Avoid using uninitialized nodeRef if there is no system root and also no specified root in the message. Thanks to Ingo or the code review.
Categories: Development

VESA: compare modes by index, instead of contents

Sat, 2016-08-20 13:14
We only compared the height, width, and depth of modes to decide if the mode was already set. However, at boot, we may have these settings right and other things not properly configured, preventing VESA to set a working mode unless forced from the boot menu. Fixes #12918 We only compared the height, width, and depth of modes to decide if the mode was already set. However, at boot, we may have these settings right and other things not properly configured, preventing VESA to set a working mode unless forced from the boot menu. Fixes #12918
Categories: Development

FontDemo: localization security fixes

Sat, 2016-08-20 12:02
- Avoid use of fixed size buffer without checks, use BString.SetToFormat instead. - Use the same format for the initial setting of the values, so there are less strings to translate, and locales using a different representation for numbers get the right thing done as well. - Fix initial label for the outline slider, which did not show the value unlike others (problem spotted by Diver, thanks!) - Avoid use of fixed size buffer without checks, use BString.SetToFormat instead. - Use the same format for the initial setting of the values, so there are less strings to translate, and locales using a different representation for numbers get the right thing done as well. - Fix initial label for the outline slider, which did not show the value unlike others (problem spotted by Diver, thanks!)
Categories: Development

Expander: fix status view.

Fri, 2016-08-19 23:31
* Truncate() would cut Unicode characters in the middle. * This commit removes arbitrary message length limit as well as workaround it was needed for and fixes #5289. * Status view now expands to maximum possible width and cuts the status message if necessary using TruncateString(). Signed-off-by: Adrien Destugues * Minor whitespace fix. * Truncate() would cut Unicode characters in the middle. * This commit removes arbitrary message length limit as well as workaround it was needed for and fixes #5289. * Status view now expands to maximum possible width and cuts the status message if necessary using TruncateString(). Signed-off-by: Adrien Destugues * Minor whitespace fix.
Categories: Development

Keymap: Follow symlink

Fri, 2016-08-19 18:09
get_ref_for_path() doesn't resolve symlinks. Construct a BEntry from the path passing 'true' for the traverse argument. That BEntry is then be passed to BDirectory's constructor. The error was hidden by the fact that the code didn't bother to error check the result of get_ref_for_path(), which would have indicated that the passed in path was a link. Thanks Rene for your help. if the entry fails to init, we are probably screwed, but, try to get the path using get_ref_for_path in that case. Worst case scenario it fails as well and the FilePanel points to your home directory. get_ref_for_path() doesn't resolve symlinks. Construct a BEntry from the path passing 'true' for the traverse argument. That BEntry is then be passed to BDirectory's constructor. The error was hidden by the fact that the code didn't bother to error check the result of get_ref_for_path(), which would have indicated that the passed in path was a link. Thanks Rene for your help. if the entry fails to init, we are probably screwed, but, try to get the path using get_ref_for_path in that case. Worst case scenario it fails as well and the FilePanel points to your home directory.
Categories: Development

Keymap: Reinitialize ref after creating Keymap dir

Fri, 2016-08-19 17:28
In the case that the Keymap directory does not exist and has to be created, reinitialize ref to the newly created directory. Thanks Stippi for your help There is still a bug present where if the Keymap directory is a symlink to another directory, the File Panel does not follow that link and instead opens to your home directory. More on this later. In the case that the Keymap directory does not exist and has to be created, reinitialize ref to the newly created directory. Thanks Stippi for your help There is still a bug present where if the Keymap directory is a symlink to another directory, the File Panel does not follow that link and instead opens to your home directory. More on this later.
Categories: Development

Revert "Keymap: Handle uninitialized ref"

Fri, 2016-08-19 17:13
This reverts commit 1e5f78f522bbdbd9af987df452d756cee4f6d32f. This reverts commit 1e5f78f522bbdbd9af987df452d756cee4f6d32f.
Categories: Development

Keymap: Handle uninitialized ref

Fri, 2016-08-19 00:27
...trying to get/make Keymaps settings dir if not able to create the Keymaps directory under settings. Resolve symlink, if it is a directory, use that directory instead, otherwise use home directory as a fallback. ...trying to get/make Keymaps settings dir if not able to create the Keymaps directory under settings. Resolve symlink, if it is a directory, use that directory instead, otherwise use home directory as a fallback.
Categories: Development

Appearance: Make color which items draggable

Thu, 2016-08-18 23:32
Create a ColorWhichListView class which impliments InitiateDrag() to drag a color square out of the list view. You can then drop the color anywhere that accepts a color drop. This allows you to drag and drop colors between list items for example. Create a ColorWhichListView class which impliments InitiateDrag() to drag a color square out of the list view. You can then drop the color anywhere that accepts a color drop. This allows you to drag and drop colors between list items for example.
Categories: Development

BListView: Impliment autoscroll

Thu, 2016-08-18 22:21
BeOS had a feature where you could click on a list and while holding down the mouse button scroll through the list items selecting them as you went. I implemented the same feature on Haiku. Did the work in separate thread which makes sure that the mouse is held down the whole time even if you leave the view. Thanks Diver for bringing this feature to my attention. BeOS had a feature where you could click on a list and while holding down the mouse button scroll through the list items selecting them as you went. I implemented the same feature on Haiku. Did the work in separate thread which makes sure that the mouse is held down the whole time even if you leave the view. Thanks Diver for bringing this feature to my attention.
Categories: Development

BListView: Use std::max() and std::min()

Thu, 2016-08-18 22:08
... in place of max_c() and min_c() respectively. ... in place of max_c() and min_c() respectively.
Categories: Development

BListView: Style fixes

Thu, 2016-08-18 22:07
* Rename kDoubleClickTresh to kDoubleClickThreshold and use floating point in rval * Pointer (*) goes with type for property var * Use {}'s for multi-line if conditional * rename point to where (consistent with header and rest of IK) * Explicitly compare with 0 for bitwise operator statements * Rename InitiateDrag() params * Rename kDoubleClickTresh to kDoubleClickThreshold and use floating point in rval * Pointer (*) goes with type for property var * Use {}'s for multi-line if conditional * rename point to where (consistent with header and rest of IK) * Explicitly compare with 0 for bitwise operator statements * Rename InitiateDrag() params
Categories: Development