Source Activity

Syndicate content
Haiku's main repository
Updated: 36 min 37 sec ago

ChannelSlider: don't check be_control_look for NULL

Wed, 2015-07-29 13:20
Also if0 the code that draws the old/dano look so it's more clear that it's not called intentionally. Also if0 the code that draws the old/dano look so it's more clear that it's not called intentionally.
Categories: Development

Add unit tests specific for #12208. Pass depends on network.

Tue, 2015-07-28 20:08
NetworkAddressTest passes (most) tests when you have network. When no network interface (ie -net none in QEMU) tests take forever and more tests fail. When network interface exists but is disabled in Haiku, tests are fast but more tests fail. NetworkAddressTest passes (most) tests when you have network. When no network interface (ie -net none in QEMU) tests take forever and more tests fail. When network interface exists but is disabled in Haiku, tests are fast but more tests fail.
Categories: Development

BChannelSlider: Fixed memory leak.

Tue, 2015-07-28 19:40
At least, I think so. Check allocations in BChannelSlider::ThumbFor()- Also updated copyright and e-mail address. At least, I think so. Check allocations in BChannelSlider::ThumbFor()- Also updated copyright and e-mail address.
Categories: Development

WebPositive: Fix "new tab opens search page".

Tue, 2015-07-28 17:16
Fixes #12251. Fixes #12251.
Categories: Development

BNetworkAddress: Address review comments.

Tue, 2015-07-28 14:14
Thanks Axel and Rene! Thanks Axel and Rene!
Categories: Development

BNetworkAddress: Fix setting fStatus all over the place.

Mon, 2015-07-27 20:17
Relevant quote from IRC: i would expect all overloads of SetTo to return status_t actually, i don't think what i would expect from class with such interface bugs probably Relevant quote from IRC: i would expect all overloads of SetTo to return status_t actually, i don't think what i would expect from class with such interface bugs probably
Categories: Development

Media: Display alert before to quit when restarting

Mon, 2015-07-27 18:16
* Fixes 10770. * While more complex solutions are proposed, i think of it as a way to get out of an eventual deadlock or to protect from accident close. * Fixes 10770. * While more complex solutions are proposed, i think of it as a way to get out of an eventual deadlock or to protect from accident close.
Categories: Development

BMediaRoster: Definitely undertake the MediaRosterUndertaker

Mon, 2015-07-27 16:08
* On a more deep analysis i figured out that other than being a bad pratice quitting the BLooper explicitly was cause of more problems, such as the regression after my patches which led to have a zombie media_addon_server after media services restart. This should hopefully place a final stone on the BMediaRoster::Quit() issue as with the previous commit i've removed every attempt to do this in the system. For any application developer listening, this means that quitting the BMediaRoster is highly discouraged, don't do it. * On a more deep analysis i figured out that other than being a bad pratice quitting the BLooper explicitly was cause of more problems, such as the regression after my patches which led to have a zombie media_addon_server after media services restart. This should hopefully place a final stone on the BMediaRoster::Quit() issue as with the previous commit i've removed every attempt to do this in the system. For any application developer listening, this means that quitting the BMediaRoster is highly discouraged, don't do it.
Categories: Development

desklink: Fix problems with BMediaRoster Quit

Mon, 2015-07-27 16:07
* Improved the situation so that it should be always synchronized. Improved error message, and detection of media services not being run. * Improved the situation so that it should be always synchronized. Improved error message, and detection of media services not being run.
Categories: Development

Remove second half of useless condition.

Sun, 2015-07-26 18:31
Thanks to Ingo for reviewing! Thanks to Ingo for reviewing!
Categories: Development

Debugger: TeamWindow refactor.

Sun, 2015-07-26 18:20
- When asked to load settings, post a message and do so in the window's message loop. This avoids a lock order reversal when asked to do so later as a result of exec() changing the target image out. - When asked to load settings, post a message and do so in the window's message loop. This avoids a lock order reversal when asked to do so later as a result of exec() changing the target image out.
Categories: Development

Debugger: Add rename event for Team.

Sun, 2015-07-26 16:57
Team: - Add listener hook and event type for rename events. These occur on exec() since at this point we're running a different executable. TeamWindow: - Factor out code for generating window title into a helper, and use from both window initialization and newly implemented rename listener hook. Team: - Add listener hook and event type for rename events. These occur on exec() since at this point we're running a different executable. TeamWindow: - Factor out code for generating window title into a helper, and use from both window initialization and newly implemented rename listener hook.
Categories: Development

test/kits/net: Fix build of cookie_test

Sun, 2015-07-26 14:55
Categories: Development

test/kits/net: Fix build of NetEndpointTest

Sun, 2015-07-26 14:47
Categories: Development

PVS 122,123: useless checks.

Sun, 2015-07-26 13:38
Categories: Development

PVS 114: useless check.

Sun, 2015-07-26 13:35
We return a few line above if err is != 0. We return a few line above if err is != 0.
Categories: Development