Source Activity

Syndicate content
Haiku's main repository
Updated: 42 min ago

DataTranslation: Fix crash

Wed, 2016-03-30 23:48
just noticed this crash... when fConfigView gets deleted by selecting a translator it deletes its child fInfoText but we were leaving the pointer alone. Afterwords if you changed the panel text color in Appearance a message gets sent that checks to see if the fInfoView pointer is NULL, and since it isn't, procedes to dereference the pointer and *boom* the app crashes. Fix this by setting the fInfoText pointer to NULL when fConfig view gets deleted. That way when you change the panel text color it doesn't attempt to dereference the stale pointer and everything works as it should. just noticed this crash... when fConfigView gets deleted by selecting a translator it deletes its child fInfoText but we were leaving the pointer alone. Afterwords if you changed the panel text color in Appearance a message gets sent that checks to see if the fInfoView pointer is NULL, and since it isn't, procedes to dereference the pointer and *boom* the app crashes. Fix this by setting the fInfoText pointer to NULL when fConfig view gets deleted. That way when you change the panel text color it doesn't attempt to dereference the stale pointer and everything works as it should.
Categories: Development

Debugger: DebuggerInterface refactor.

Tue, 2016-03-29 21:49
DebuggerInterface: - Refactor into abstract base class. - Introduce interface configuration abstract base class. - Move existing implementation into LocalDebuggerInterface and add corresponding configuration class. Debugger: - Adjust to instantiate LocalDebuggerInterface. In and of itself no functional change, but paves the way for further refactoring to make the debugger fully interface-agnostic (this isn't yet the case for retrieving target system information such as the team listing, and creating/attaching to teams). DebuggerInterface: - Refactor into abstract base class. - Introduce interface configuration abstract base class. - Move existing implementation into LocalDebuggerInterface and add corresponding configuration class. Debugger: - Adjust to instantiate LocalDebuggerInterface. In and of itself no functional change, but paves the way for further refactoring to make the debugger fully interface-agnostic (this isn't yet the case for retrieving target system information such as the team listing, and creating/attaching to teams).
Categories: Development

Debugger: Minor refactor.

Tue, 2016-03-29 21:44
TeamDebugger: - Rather than instantiating the DebuggerInterface directly, we now expect it to be given to us externally. This allows TeamDebugger to be agnostic of where the team actually resides. Debugger: - Create and initialize DebuggerInterface before passing it on to TeamDebugger. No functional change. TeamDebugger: - Rather than instantiating the DebuggerInterface directly, we now expect it to be given to us externally. This allows TeamDebugger to be agnostic of where the team actually resides. Debugger: - Create and initialize DebuggerInterface before passing it on to TeamDebugger. No functional change.
Categories: Development

Netboot: remove rtl8169 driver from boot archive

Tue, 2016-03-29 20:13
This driver was replaced by rtl81xx. Having both in the image results in conflicts and non-working ethernet. This driver was replaced by rtl81xx. Having both in the image results in conflicts and non-working ethernet.
Categories: Development

NetBoot: add the notification module to boot symlinks

Tue, 2016-03-29 19:10
- There is no point in having it in the boot image if it can't be used. - This however does not get the system booting. - There is no point in having it in the boot image if it can't be used. - This however does not get the system booting.
Categories: Development

BufferManager: Remove custom hash key

Mon, 2016-03-28 18:56
Categories: Development

MediaPlayer: Fix logic inversion

Sun, 2016-03-27 19:49
Categories: Development

MediaPlayer: Fix style in Playlist.h

Sun, 2016-03-27 19:29
Categories: Development

Make some headers C89 safe again

Sun, 2016-03-27 14:58
- Allows to use FindDirectory.h in C89 sourcecode (no C++ style comments allowed) - Allows to use FindDirectory.h in C89 sourcecode (no C++ style comments allowed)
Categories: Development

Update translations from Pootle

Sat, 2016-03-26 06:27
Categories: Development

PluginManager: Fix build for x86_64

Fri, 2016-03-25 23:35
Categories: Development

BShape: Fix issues for debug build.

Fri, 2016-03-25 23:32
As part of the refactoring that was done for app_server layer support, the private shape_data struct was updated to derive from BReferenceable. However, BShape's destructor was never updated to reflect this, and consequently attempts to use a debug build of libbe would consistently throw the user into the debugger due to BReferenceable's sanity check against non-zero deletes that weren't on the stack. It should be noted though that there are probably a few things that could be factored out and/or simplified with that class in general, since e.g. when copying its data from another shape_data instance, it uses C++ array allocations, while when being manipulated by BShape directly, the latter uses alloc/realloc/free. As part of the refactoring that was done for app_server layer support, the private shape_data struct was updated to derive from BReferenceable. However, BShape's destructor was never updated to reflect this, and consequently attempts to use a debug build of libbe would consistently throw the user into the debugger due to BReferenceable's sanity check against non-zero deletes that weren't on the stack. It should be noted though that there are probably a few things that could be factored out and/or simplified with that class in general, since e.g. when copying its data from another shape_data instance, it uses C++ array allocations, while when being manipulated by BShape d