Latest Bugs & Tasks

Syndicate content Haiku
Trac Timeline
Updated: 1 hour 10 min ago

Ticket #12832 ([Patch] JobSetupWindow.cpp: fix clang warning) created

Sun, 2016-06-26 11:00

Since 'lastPage' is int32, use INT32_MAX instead of LONG_MAX.

/home/haiku/haiku/haiku/src/add-ons/print/drivers/preview/JobSetupWindow.cpp:45:45: warning: comparison of constant 9223372036854775807 with expression of type 'int32' (aka 'int') is always false [-Wtautological-constant-out-of-range-compare]
        bool allPages = firstPage == 1 && lastPage == LONG_MAX;
                                          ~~~~~~~~ ^  ~~~~~~~~
Categories: Development

Ticket #12831 ([Patch] cddb_server.cpp: fix clang warnings) created

Sun, 2016-06-26 10:58

Since 'port' is int32, use INT32_MAX and INT32_MIN instead of LONG_MAX and LONG_MIN.

/home/haiku/haiku/haiku/src/bin/cddb_lookup/cddb_server.cpp:315:34: warning: comparison of constant 9223372036854775807 with expression of type 'int32' (aka 'int') is always false [-Wtautological-constant-out-of-range-compare]
                        if ((errno == ERANGE && (port == LONG_MAX || port == LONG_MIN))
                                                 ~~~~ ^  ~~~~~~~~
/home/haiku/haiku/haiku/src/bin/cddb_lookup/cddb_server.cpp:315:54: warning: comparison of constant -9223372036854775808 with expression of type 'int32' (aka 'int') is always false [-Wtautological-constant-out-of-range-compare]
                        if ((errno == ERANGE && (port == LONG_MAX || port == LONG_MIN))
                                                                     ~~~~ ^  ~~~~~~~~
Categories: Development

Ticket #12830 ([Patch] print/drivers/pdf/source/PictureIterator.h: fix header guard ...) created

Sat, 2016-06-25 13:08

Fix header guard spelling as clang point out.

/home/haiku/haiku/haiku/src/add-ons/print/drivers/pdf/source/PictureIterator.h:32:9: warning: '_PICTURE_ITERATOR_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
#ifndef _PICTURE_ITERATOR_H
        ^~~~~~~~~~~~~~~~~~~
/home/haiku/haiku/haiku/src/add-ons/print/drivers/pdf/source/PictureIterator.h:33:9: note: '_PICTURE_TIERATOR_H' is defined here; did you mean '_PICTURE_ITERATOR_H'?
#define _PICTURE_TIERATOR_H
        ^~~~~~~~~~~~~~~~~~~
        _PICTURE_ITERATOR_H
Categories: Development

Ticket #12829 ([Patch] mediaplayer/interface/PeakView.h: fix header guard spelling) created

Sat, 2016-06-25 13:05

Fix header guard spelling as clang point out.

/home/haiku/haiku/haiku/src/apps/mediaplayer/interface/PeakView.h:30:9: warning: 'PEAK_VIEW_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
#ifndef PEAK_VIEW_H
        ^~~~~~~~~~~
C++ /home/haiku/haiku/haiku/generated-clang/objects/haiku/x86_64/release/apps/mediaplayer/SeekSlider.o
/home/haiku/haiku/haiku/src/apps/mediaplayer/interface/PeakView.h:31:9: note: 'PEAL_VIEW_H' is defined here; did you mean 'PEAK_VIEW_H'?
#define PEAL_VIEW_H
        ^~~~~~~~~~~
        PEAK_VIEW_H
Categories: Development

Ticket #12828 ([Patch] haikudepot/model/PackageActionHandler.h: fix header guard spelling) created

Sat, 2016-06-25 13:03

Fix header guard spelling as clang point out.

/home/haiku/haiku/haiku/src/apps/haikudepot/model/PackageActionHandler.h:6:9: warning: 'PACKAGE_ACTION_HANDLER_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
#ifndef PACKAGE_ACTION_HANDLER_H
        ^~~~~~~~~~~~~~~~~~~~~~~~
/home/haiku/haiku/haiku/src/apps/haikudepot/model/PackageActionHandler.h:7:9: note: 'PACkAGE_ACTION_HANDLER_H' is defined here; did you mean 'PACKAGE_ACTION_HANDLER_H'?
#define PACkAGE_ACTION_HANDLER_H
        ^~~~~~~~~~~~~~~~~~~~~~~~
        PACKAGE_ACTION_HANDLER_H
Categories: Development

Ticket #12827 (Include Packagebuilding into makefile_engine) created

Wed, 2016-06-22 17:05

It would be a really good idea to include .packageInfo generation and package building into the makefile_engine. Since makefile already contains all libs which the program is linked to the dependencies shouldn't be the biggest problem. For all other information there could be variables defined.
This would be really really helpful and would make life much much more easier.

Categories: Development

Ticket #12826 ([Patch] echo/multi.cpp: Fix clang warnings) created

Tue, 2016-06-21 21:43

Clang warns 'id < 0' conditons. Since multi_mix_value_info->values[i].id is int32 [1], so I think we may change variable 'id' from uint32 to int32. And I think other audio drivers also need to change.

[1] ​http://cgit.haiku-os.org/haiku/tree/headers/private/media/hmulti_audio.h#n427

/home/haiku/haiku/haiku/src/add-ons/kernel/drivers/audio/echo/multi.cpp:258:10: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
                if (id < 0 || id >= card->multi.control_count) {
                    ~~ ^ ~
/home/haiku/haiku/haiku/src/add-ons/kernel/drivers/audio/echo/multi.cpp:300:10: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
                if (id < 0 || id >= card->multi.control_count) {
                    ~~ ^ ~
/home/haiku/haiku/haiku/src/add-ons/kernel/drivers/audio/echo/multi.cpp:311:12: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
                                if (id < 0 || id >= card->multi.control_count) {
                                    ~~ ^ ~
Categories: Development

Ticket #12825 ([Patch] net_buffer.cpp: Fix clang warning) created

Tue, 2016-06-21 21:35

In remove_header(), 'while (left >= 0)' at line 1823 is always true because 'left' is unsigned. so I think we may change condition to 'while (left > 0)'.

/home/haiku/haiku/haiku/src/add-ons/kernel/network/stack/net_buffer.cpp:1823:14: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
        while (left >= 0) {
               ~~~~ ^  ~
Categories: Development

Ticket #12824 ([Patch] partitioning_systems/gpt/utility.cpp: Fix clang warnings) created

Tue, 2016-06-21 21:29

In to_utf8(), clang warns '-Wtautological-constant-out-of-range-compare warnings'. I think we may increase variable 'c' size from uint16 to uint32 at line 41.

/home/haiku/haiku/haiku/src/add-ons/kernel/partitioning_systems/gpt/utility.cpp:50:16: warning: comparison of constant 65536 with expression of type 'uint16' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
                } else if (c < 0x10000) {
                           ~ ^ ~~~~~~~
/home/haiku/haiku/haiku/src/add-ons/kernel/partitioning_systems/gpt/utility.cpp:54:16: warning: comparison of constant 1114111 with expression of type 'uint16' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
                } else if (c <= 0x10ffff) {
                           ~ ^  ~~~~~~~~
Categories: Development

Ticket #12823 (Implement an accessibility preflet) created

Tue, 2016-06-21 18:43

Other operating systems have accessibility preferences of some type.

On Haiku it could contain the preferences for:

  • Language accessibility (system spellchecker & autocorrect)
  • Input accessibility (virtual keyboard configuration, ​cursor highlighting, cursor size, numpad mouse)
  • Speech recognition (dictation & voice commands)
  • Speech synthesizer (screen reader & system text-to-speech service)
  • Screen accessibility (high contrast, colour invert, grayscale)
  • Audio accessibility (visual alerts/screen flashing, force mono sound, audio balancing)

On OSX, standard preferences that might be somewhat relevant to an accessibility need are linked to from the accessibility preferences window (i.e. Screen accessibility tab would have a link to the Appearance preflet so the user can change the system text size).

Categories: Development

Ticket #12388 (Missing support for TLS SNI (easy)) closed

Mon, 2016-06-20 23:50
fixed:

Applied in hrev50368 -- sorry, jessicah, I saw your comment after committing.

Categories: Development

Ticket #12822 ([Patch] xhci.cpp: Fix -Wtautological-constant-out-of-range-compare) closed

Sun, 2016-06-19 09:55
fixed:

Applied with a build fix in hrev50365. Thanks!

Categories: Development

Ticket #8254 (bfs_fuse needs root privs since hrev41258) closed

Sun, 2016-06-19 02:56
fixed:

Applied in hrev50364. Thanks (and apologies for the very long delay!)

Categories: Development

Ticket #12822 ([Patch] xhci.cpp: Fix -Wtautological-constant-out-of-range-compare) created

Sun, 2016-06-19 02:15

In xhci.cpp, clang warns '-Wtautological-constant-out-of-range-compare'. I think we may change fScratchpadCount size to compare with XHCI_MAX_SCRATCHPADS.

/home/haiku/haiku/haiku/src/add-ons/kernel/busses/usb/xhci.cpp:427:23: warning: comparison of constant 1024 with expression of type 'uint8' (aka 'unsigned char') is always false [-Wtautological-constant-out-of-range-compare]
        if (fScratchpadCount > XHCI_MAX_SCRATCHPADS) {
            ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
Categories: Development

Ticket #12799 (Unit test BClipboard::Clear1 crashes) reopened

Sat, 2016-06-18 22:58

Had to revert the change, it was failing on the buildbots (e.g. ​http://buildbot.haiku-os.org/builders/haiku-master-x86/builds/2767).

Categories: Development

Ticket #12710 (BPackageInfo; URL Validation Checks) closed

Sat, 2016-06-18 22:41
fixed:

Applied in hrev50362. Thanks!

Categories: Development

Ticket #12799 (Unit test BClipboard::Clear1 crashes) closed

Sat, 2016-06-18 22:19
fixed:

Applied in hrev50361. Thanks!

Categories: Development

Ticket #12575 (Tracker ignores 24 hour format) closed

Sat, 2016-06-18 22:19
fixed:

Applied in hrev50361. Thanks!

Categories: Development

Ticket #12821 (BView::GetMouse() sometimes crashes if the BPoint* parameter is NULL) created

Sat, 2016-06-18 21:43

​http://xref.plausible.coop/source/xref/haiku/src/kits/interface/View.cpp#1597 passes _location to FindPoint() without checking if it's NULL or not.

Found while working on the new Mandelbrot app.

Categories: Development