Development mailing list

Syndicate content
Archive of posts for haiku-development at FreeLists
Updated: 16 min 51 sec ago

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Axel Dörfler)

Fri, 2015-12-04 09:45
Am 22.11.2015 um 02:40 schrieb looncraz: My final patch, located here: Next round of review, still not through, but I think I got all the important things. First of all, I think the API changes in BView are a nice addition, and also nicely done. ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (looncraz)

Thu, 2015-12-03 20:45
On 11/23/2015 13:47, John Scipione wrote: I’m running with your patch applied. Default button border color has changed to light blue, should be grey by default. Other than that it is really nice, color changes happen instantaneously! ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (John Scipione)

Thu, 2015-12-03 16:45
I’m running with your patch applied. Default button border color has changed to light blue, should be grey by default. Other than that it is really nice, color changes happen instantaneously! ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Jérôme Duval)

Thu, 2015-12-03 12:45
2015-11-23 18:21 GMT+01:00 Alexander von Gluck IV kallisti5@xxxxxxxxxxx: To be clear, the bug affecting nano is in Haiku... these replies seem to imply otherwise... I'm surprised this bikesheding of the default install comes somehow yet again, we use a package manager for a reason. Bye, Jérôme ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Alexander von Gluck IV)

Thu, 2015-12-03 12:45
November 22 2015 1:30 PM, Adrien Destugues pulkomandy@xxxxxxxxx wrote: correct typos in the commits from within Haiku. And I forgot to reply about this: the current default editor is Nano, which has been broken for years, and still is. There was a vote years ago to remove vi from the image (despite it being required by POSIX) and ship with Nano as the default editor). It seems no one uses it (or ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (looncraz)

Thu, 2015-12-03 10:45
On 11/22/2015 15:59, Stephan Aßmus wrote: fCountViews[i]-SetViewUIColor(ViewUIColor(tint), tint); The tint value doesn't need to change, not sure why I have that there. I will make a commit with these changes, I will await any further discoveries you may make in HaikuDepot before that so I can group the ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (looncraz)

Thu, 2015-12-03 10:45
On 11/22/2015 15:53, Stephan Aßmus wrote: + + SetFlags(Flags() B_DRAW_ON_CHILDREN | B_WILL_DRAW); + } What is supposed to happen here? Did you mean SetFlags(Flags() | B_DRAW_ON_CHILDREN | B_WILL_DRAW); ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (looncraz)

Wed, 2015-12-02 06:45
On 11/22/2015 15:44, Stephan Aßmus wrote: Hi, Howdy! Scrollbar in the browser window tells me I am still below 25% of the complete patch. ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Stephan Aßmus)

Wed, 2015-12-02 06:45
Hi, Am 22.11.2015 um 02:40 schrieb looncraz: My final patch, located here: style corrections even for code that I did not create. I have tried to be as patient as I can be, and have addressed every concern presented to me in a timely and, I hope, courteous manner. I have done this for almost exactly two months now, and have effectively rewritten this patch ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Stephan Aßmus)

Wed, 2015-12-02 00:45
Hi, Am 22.11.2015 um 02:40 schrieb looncraz: My final patch, located here: style corrections even for code that I did not create. I have tried to be as patient as I can be, and have addressed every concern presented to me in a timely and, I hope, courteous manner. I have done this for almost exactly two months now, and have effectively rewritten this patch ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Stephan Aßmus)

Tue, 2015-12-01 20:45
Hi, Am 22.11.2015 um 02:40 schrieb looncraz: My final patch, located here: style corrections even for code that I did not create. I have tried to be as patient as I can be, and have addressed every concern presented to me in a timely and, I hope, courteous manner. I have done this for almost exactly two months now, and have effectively rewritten this patch ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (looncraz)

Tue, 2015-12-01 20:45
On 11/22/2015 13:48, Axel Dörfler wrote: As I said: please get the basics done first. I'm really only pissed at you since you claimed you had gone to lengths to fix all coding style issues when you in fact have not. I ran every tool, and was pretty sure I had managed to get rid of the style issues. I have addressed every issue you presented, and scanned for other examples of them, and missed a couple. You do realize that ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Stephan Aßmus)

Tue, 2015-12-01 18:45
Hi, Am 22. November 2015 20:28:32 schrieb Adrien Destugues pulkomandy@xxxxxxxxx: On Sun, Nov 22, 2015 at 01:16:00PM -0600, looncraz wrote: On 11/22/2015 13:02, Dario Casalinuovo wrote: Hi, ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (looncraz)

Tue, 2015-12-01 16:45
On 11/22/2015 13:30, Jérôme Duval wrote: You said you found a bug in the existing LinkReceiver implementation: this would deserve a single patch submission. Yes, a very simple bug that caused big problems for me, but would not for anyone else. ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (looncraz)

Tue, 2015-12-01 14:45
On 11/22/2015 13:24, Adrien Destugues wrote: I think you underestimate the importance of the coding style. No, I appreciate the importance to having a generally consistent style, but it should not be the greatest priority. ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Adrien Destugues)

Tue, 2015-12-01 08:45
On Sun, Nov 22, 2015 at 08:54:22PM +0100, Jérôme Duval wrote: in-tree. Our current vim package includes not only vim, but a lot of syntax files, the GUI enabled gvim, etc. It could be split if needed. Even then, I can't think now of vim as a modern default text editor for Haiku, a bit too old fashioned maybe ;) ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Jérôme Duval)

Tue, 2015-12-01 01:45
2015-11-22 20:41 GMT+01:00 Adrien Destugues pulkomandy@xxxxxxxxx: in-tree. Our current vim package includes not only vim, but a lot of syntax files, the GUI enabled gvim, etc. It could be split if needed. Even then, I can't think now of vim as a modern default text editor for Haiku, a bit too old fashioned maybe ;) Bye, ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Axel Dörfler)

Tue, 2015-12-01 01:45
Am 22.11.2015 um 18:57 schrieb looncraz: First, to Axel: Have you actually tried running the patched system? Any comments on how it works? As I said: please get the basics done first. I'm really only pissed at you since you claimed you had gone to lengths to fix all coding style ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (Adrien Destugues)

Mon, 2015-11-30 07:45
On Sun, Nov 22, 2015 at 08:36:44PM +0100, Jérôme Duval wrote: correct typos in the commits from within Haiku. And I forgot to reply about this: the current default editor is Nano, which has been broken for years, and still is. There was a vote years ago to remove vi from the image (despite it being required by POSIX) and ship with Nano as the default editor). It seems no one uses it (or ...
Categories: Development

[haiku-development] Re: Final Set*UIColor Patch, Version 3e (scottmc)

Mon, 2015-11-30 04:45
Running lpe ... Damn the autocorrect. ...
Categories: Development