WebKit weekly report #18
Hi there! As you can read on the frontpage, I’ll continue working for Haiku in february.This will be the 5th month of this contract. Thanks to everyone who donated to Haiku, Inc for making this possible!
So, I’ve sorted out my filesystem issues over the week-end (no important data was lost), and I’m back to full-speed work. As I was saying last week, we had a problem with gcc4.7 not compiling the most recent WebKit code. I expected an update to gcc4.8 to solve this, but it didn’t. What was needed is an extra configure option to enable C++11 threads support, as WebKit started using that and gcc doesn’t autodetect the required OS support.
So, I rebuilt gcc with the needed option, and could get WebKit updated again, merging the work done at WebKit in december and january. As usual, not much crazy new features, but a lot of refactoring and cleanup. The API to manage the mouse cursor was changed to a simpler one that wastes less time and memory allocating stuff, some compile-time options were removed as all ports used the same value, and some custom classes were replaced with C++11 standard equivalents. This is made possible because of the release of a new version of Visual Studio, which still lacked some of these features. Of interest to us is the use of C++11 override. This comes from Java and allows to tell the compiler that a given method in a class should replace one from a base class. If it doesn’t, you get a compile error. This is very useful in WebKit, as it allows detecting when the base class API changed (method removed or renamed, parameters added or removed, types changed, …). I started adding the “override” keyword to some of the Haiku specific classes, and could remove a dozen of useless methods. This is one little change that will make further upgrades much easier. Another change is the deprecation of the history API we were using. This was the occasion to clean up our old code for this and get the back/forward buttons to work more reliably.
So, I started testing the new WebKit and noticed it was very crashy, with testsuite results as low as 4000 passing tests out of 32000 (ouch!). At least part of this was found to be caused by stricter stack alignment requirements on gcc side. gcc4.8 started using more x86 instructions that need 16-byte stack alignment. Before this only happened in some well-defined parts of the code, and I could fix this on a function-by-function basis. Now, all the code using floating point numbers is potentially affected. I can work around this by compiling all of WebKit with the -mstackrealign option, however this is something that should be fixed on Haiku side. Fortunately, the fix shouldn’t be too complicated, it’s just a change of the alignment constraint we have to do when creatign a new thread. If the initial alignment is correct, gcc generates code that always preserves it, unless you have some non-gcc compiled code in your function call stack (hand-written assembly code is one possible case of this).
There is apparently another crash related to the new mouse cursor code, which I haven’t investigated yet. With these two out of the way, I’ll have to run the testsuite again and see if there are other problems. With so few passing tests, the result html page (which list everything that failed) is too slow to browse and barely useable.
On to the new features now: it was more than time we fix the drawing glitches known as “border bleeding”. You probably have noticed this problem on the side menu of this very website. There are some other places affected by this. Anyway, stippi did an amazing job of implementing ClipToPicture the right way. We now have a very fast implementation that also supports antialiasing. Bridging the gap between old and new apps, this improves the situation for both Gobe Productive (one of the few apps to use this API in BeOS days) and WebKit.
I had the code using ClipToPicture mostly ready in WebKit, waiting for the working implementation in Haiku. I could finally test it this morning and… well it doesn’t work perfectly, yet. While it fixes the border bleeding, and we get our gradients where they should be again, when scrolling the page too fast (with pageup/pagedown buttons for example), the text above the gradients isn’t drawn at all. Other websites also get new drawing problems in similar situations. I’m not sure what happens yet.
While stippi was working in app_server internals again, he also started implementing arbitrary view transforms. We had most of the API ready, with the BAffineTransform class available but only used to transform BPolygons. You can now set a transformation on a view and arbitrary rotate, scale, translate and otherwise distort all the drawing. This is all new and not yet completely tested (and in fact, there are some known bugs). But, it will allow a huge improvement of WebKit SVG rendering once it gets plugged in WebKit’s GraphicsContext class.
I’m also trying to get some other devs into WebKit development, as working alone isn’t fun. I’ve opened one “easy” issue on our bugtracker. It’s about implementing Web Sockets support. There are some other things I would like to see done by others, for example support for web notifications using the BNotification API. Wouldn’t it be nice to have a pop-up showing messages from gmail web page show next to the deskbar? Send in your patches!
- [GSoC 2017] Porting Swift to Haiku - Week #4 #5
- [GSoC2017: Harfbuzz] Report #3
- [GSoC 2017] Preferences GUI Refactoring - Weekly Report 3
- [GSoC 2017] Calendar Application: Weekly Report 3
- [GSoC 2017] 3D Hardware Acceleration - Weekly Report 3
- [GSoC 2017 - BTRFS Write Supports] Week #4 #5
- [GSoC 2017] Preferences GUI Refactoring - Weekly Report 2
- [GSoC 2017] Porting Swift to Haiku - Week #3
- Haiku monthly activity report - 05/2017